arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
819 stars 55 forks source link

Insufficient performance in parsing long video's subtitles and somehow a correlation to timestamps not saving properly ( my layman's recount of this issue) #360

Open Katsumi-III opened 4 months ago

Katsumi-III commented 4 months ago

I just want to put this here for the sake of keeping records. I was using jidoujisho's video functionality for sub 30 minute videos with subtitles and timestamps being saved. When I started watching a 2h+ video, then came back to watch 9h+ live stream vod, realized subtitles weren't loading, watched for a bit, left and came back, realize the timestamps don't save past 9 minutes into the video, kept trying a few things, disabled duckduckgo app tracker-blocker for jidoujisho, forced shutdown the app, attempted to check if timestamps save and subtitles load, realize it doesn't, checked the other 2h+ video and found out it's having the same issue. After I had waited for 3 minutes on the "Subtitles processing" window on the 9h+ vod, I decided to wait 13 minutes on the same window but on the 2h+ video. There was no change until I left that window and the Subtitles appeared, checked again that subtitles processing window again by swiping up, and now the transcript appears. After this ordeal, timestamps save and the 9h+ vod now loads its subtitles and shows the transcript, and properly saves timestamps. Not sure what happened but, in case this reveals something in the future I'll submit this issue. Maybe, it was duckduckgo's anti-tracking but, why did smaller videos not have this issue?

Samsung S23 One UI 6 Android 14

Katsumi-III commented 4 months ago

Update: just now, after submitting this issue a few minutes ago the 9h+ vod started having the same issues again. The 2h+ video too. I left the app after submitting the issue. And came here to add this comment once I came back to the app and realized I have the issue again. Maybe leaving the video paused like last time, except, probably don't need to have the "subtitles processing" window opened the whole time.

Katsumi-III commented 4 months ago

https://github.com/lrorpilla/jidoujisho/releases/tag/2.8.9 Running 2.8.9

arianneorpilla commented 4 months ago

This is known and expected behaviour as is and a performance issue when parsing very long auto generated subtitles from YouTube.

If someone wishes to improve this, you can look into how the subtitles are parsed and improve the algorithm there.