arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
819 stars 55 forks source link

Subtitles not passed when watching from Jellyfin #364

Open shinthor opened 4 months ago

shinthor commented 4 months ago

Trying to stream from jellyfin with a show with external subtitles, the subtitles show up fine on the latest version of the Jellyfin app and server, but when using jidoujisho as an external player, they do not show up, I get the message "Embedded subtitles are unsupported for network streams, which is the same issue as #91 but was supposed to be resolved by release 2.4 if using external file subtitles, which I am.

This is trying with release 2.8.9, running Jellyfin version 10.8.13 and jellyfin android app version 2.6.0.

arianneorpilla commented 4 months ago

I believe this is an issue that occurs with using a later version of the Jellyfin app. There's a note in the 2.9.0 preview as a known issue, and the fix for now is to stay on that Jellyfin app version that hasn't broken the subtitle arg passing in the intent, while I'm too busy to get to this

shinthor commented 4 months ago

Thank you, just confirming that this setup does work with Jellyfin android version 2.5.3 from F-droid, the subtitles show up and words are selectable with the imported popup dictionaries.