search

ariatemplates / hashspace

JavaScript client-side template engine
http://hashspace.ariatemplates.com
Apache License 2.0
14 stars 18 forks source link

feat: Implementation of the select element #304

Closed fbasso closed 9 years ago

b-laporte commented 9 years ago

Good to see that you added a sample in the playground ! - but I think the current input sample is already cluttered, so IMO select deserves a dedicated sample page showing uses cases such as binding and list content change... thx

fbasso commented 9 years ago

Thanks for your feedbacks! I'm going to change the code accordingly as well as fixing the cross browser issues reported in Travis.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.23%) when pulling 8c8ff4d47c486ac6cd438c182a1ecff4ee65c1d9 on fbasso:select into 711d77def946837abfd5525a56140acb442338d2 on ariatemplates:master.

benouat commented 9 years ago

@fbasso Could you please have a look at my review comments above please ?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.23%) when pulling 456ec8e3c47ce534af2da0c5060319bc228524dc on fbasso:select into b6e377679c7d0dfa2faeb26fcac74ba5167b7d5f on ariatemplates:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.22%) when pulling 7815aa2ea4b195645865edc93b38f5498edcaf43 on fbasso:select into 771662d32c712f957fd90cf8e96316e4bd4f441a on ariatemplates:master.