HTML syntax part 3

[jakub-g]

This is still WIP but I'm opening a PR already, since it's huge, so that someone can start reviewing (I'll add new commit with some tests, the src should be untouched or barely touched)

Almost all 200 files changed are just syntax update in HSP files. In some of the test files I had to tweak error messages since the way parser works has changed.

---

In first commit the two most interesting changes are hspblocks.pegjs and syntaxTree.js

• lots of changes to support HTMLish definition of args, controller, export, newly-added export-module and id + lot of validation code
• removed assertions concerning modifiers at the beginning of the statement (<export template) since it's no longer supported (now it's always <template maybe-export-here>
• changed mod to modifier in the syntax tree, and now it's an object or null instead of string or empty string (to support export="foo")
• errtests.js: added a few lines to aid debugging in case of template parse errors
• added suberrors array to syntax tree in case of <template>-statement parsing errors to be more detailed (see template8.txt for instance)
• some whitespace changes (my editor somehow replaced tabs with spaces, and removed trailing whitespace, IMO it's fine)

Due to the way how HTML attributes are parsed, I had to change some tests (template8 once again for instance)

In hspblocks, crazily big amount of code is for error handling to have friendly messages instead of terse parse errors. For that I modified the HTMLAttribute to be more readable and provide code which is propagated to the template in case of template opening statement parse error.

In the last commit I added the suberrors-awareness to the playground, this meant having to modify log to output messages array apart from message string, so that I can format them the way I want (i.e. <br>-separated), because currently in hashspace it's impossible to easily do any kind of pre-display manipulation like e.g. introducing HTML newlines in a multiline string I kept message too (which just joins lines with a space) for backward compat (there were some failing log tests, I didn'qt want to touch it) In the JS generator code I took advantage of the fact that log methods can have varags input.

Notable missing parts:

• args and ctrl can have only "value" inside double quotes, not inside single quotes unlike other attribs
• introduced export-module which when parsed sets node.isExportModule = true for now in the syntax tree but nothing more than that (it doesn't perform the exporting functionality)
• no checking for multiple conflicting exports, export-module etc
• export can have value <template id=foo export=bar> and then block.modifier.exportName is available (null if not set), but nothing is done with it further, it's just parsed (template is still exported as foo instead of bar)

[jakub-g]

Naturally I recommend using GH code review assistant to handle the hugeness of the PR ;)

[divdavem]

@jakub-g For info, I have done a rebase of your branch on the most recent commits from https://github.com/ariatemplates/hashspace, resolving some conflicts. Here is the resulting branch on my fork: https://github.com/divdavem/hashspace/tree/jakub-htmlsyntax-part3

[jakub-g]

I've added a number of tests in the last commit. There are still some missing features to be added (listed them in the first message of this PR) but this PR is big enough already - they can be added later on.

Anyone brave enough to review this monster? :)

One obvious downside of this PR I can already tell is that TemplateStart in hspblocks got really huge. Probably for debugging sake, it could be better to move this code to the later stage so you could run it with node-inspector and put breakpoints etc. OTOH it turned out it was pretty convenient for me to use http://pegjs.majda.cz/online for real-time evaluation of parse tree.

[coveralls]

Coverage increased (+0.1%) when pulling c974ff81d3e1853dbfe22792843f548d031eb86f on jakub-g:htmlsyntax-part3 into 897c7ebc744058847f9a37c9b767ef4057b275a1 on ariatemplates:master.

[marclaval]

LGTM

[jakub-g]

@mlaval thanks for review @divdavem thanks for rebasing and resolving conflicts :)