search

aribis369 / ML-Starter-Pack

A collection of Machine Learning algorithms written from sctrach.
75 stars 51 forks source link

NaiveBayes And SVM #19

Closed Culeshovi closed 6 years ago

Culeshovi commented 6 years ago

A Naive Bayes and SVM algorithm written from Scratch.

aribis369 commented 6 years ago

@Culeshovi Nice work. But one problem is that @imVivekGupta has already worked on SVM and I have merged it. Your's is good, so you have to just change the file name of your ipynb file and upload it. Another thing before all this, please be very descriptive while writing your Notebooks. These notebook may be read by beginners and should act as a tutorial and not as plain codes. So hoping you make your notebooks more descriptive, then I will merge your PR.

aribis369 commented 6 years ago

@Culeshovi Can you make your notebooks a little descriptive. Can you work on this, then I will merge your PR.

Culeshovi commented 6 years ago

@aribis369 Ok. I'll do the changes.

Culeshovi commented 6 years ago

@aribis369 Is this ok?

aribis369 commented 6 years ago

@Culeshovi Nice work.

aribis369 commented 6 years ago

Merged.