ariccio
commented
6 years ago Sorry I'm so far behind on maintaining this project! (life, ya know?) I'm working on getting back into normal development - the biggest issue I've had is that the behavior of std::async changed dramatically from VS2013 to VS2015, and remained that way in VS2017. I'm basically the only person who's using it this way, so I'm not gonna make a biiiig deal about implementation defined behavior. Basically, in 2015+, it's launching a new thread for every new directory encountered, which quickly brings the whole program to a hang/deadlock. Ooops. Since I'm so anal about using the latest toolchain, I can't really even push a new release that works. Now that more than one person (me) is actually using this program, I'm coming back to it, and trying to rewrite the async code to fix this issue, and probably even speed the program up a bunch more. Async/highly parallel programming is hard, and it's hard enough to reason about the main enumeration codepath as-is, let alone rewrite it. I shouldn't complain, since I got myself into this on purpose, trying to write highly parallel code and all. Hopefully coroutines will help, and I just started writing some emails for help understanding C++ coroutines, right before I decided to answer your issue.
But none of that really answers your question. Sorry! But I hope it helps clear up confusion about my absence for others. Back to your question.
So, my guess for the first issue is that you're building from the tip, which is not gonna work with VS2013, since I started working on VS 2015 sometime after the last release, which was 13398927eac58995884b1409c429f5cb9fe77fc3 - if you're building on VS2013, try that. Oh, and the code is kinda a mess right now as I figure out how to fix this cleanly. (I've been dicking around in this repo: https://github.com/ariccio/FindFileBench_cleaned_up/tree/new_async_test)
Regarding CTP, probably the same thing.
The toolchain & installed programs list would probably be helpful if it were actually something wrong, rather than the repo just being in a mutant/aborted surgery/hybrid state, but again, this is my fault right now, not yours.
I'm apparently late enough to this party that the _Iterator screenshot is gone, but it sounds unfun, and I'll bet it has something to do with errors somewhere else. Maybe insert it into the issue when you see it again? God I hate link rot.
Is the WTL issue just me not updating to the latest distribution? I'm crazy enough that maybe I'll ditch WTL altogether (once I expunge MFC's rotting corpse from this repo) by manually rewriting all that code. My aversion to dependencies in small projects is what has kept me from using Boost's ASIO/AFIO for all the async stuff, which probably would've made my code simpler, but I've had so much trouble getting Boost to compile in other people's small open source code that I decided that I didn't want to subject anybody else to it 😆 🤣
Thanks for actually caring enough to compile my code, and sorry for taking almost a year to respond! I'll (hopefully) fix this soon.
RichardMeadowsTC
I have tried to compile this project Under the VS2013 toolchain. It did not like that, saying: "constexpr" undeclared. https://puu.sh/wVfg2/77385effcd.png This lead me to searching, and trying the Visual C++ Compiler November 2013 CTP, and that toolchain, but selecting the CTP_Nov2013 toolchain gives worse errors: https://puu.sh/wVf8J/7cd58958a7.png To clarify: I'm on Windows 10 LTSB build 10240, with VS Pro 2010, Ultimate 2013(update 5), Community 2015(Update3), Community 2017(15.2), and Windows 7 and Win 10 SDK. What else would I need? How did you manage to use Constexpr on VS 2013 ?
This is my toolchain list: https://puu.sh/wVf4N/886470d74b.png This is what my installed programs list looks like: https://puu.sh/wV7Gy/f57c12f42d.png
With the VS2015 toolchain, I get weird errors about _Iterator https://puu.sh/wV7N3/357a658d8c.png
In case anyones reading this and is wondering about the "NuGet" errors, I fixed that by not using WTL 9.1.1 and using the 9.1 that was already provided, just re-activate it by going to Nuget Package Manager Console and doing: