search

arichiardi / replumb

ClojureScript plumbing for your self-hosted REPLs.
http://clojurescript.io
Eclipse Public License 1.0
210 stars 16 forks source link

Added support for user provided eval fn #200

Closed jgrimes closed 6 years ago

jgrimes commented 8 years ago

Fixes #199

Just adds :eval to the set of user supplised options, and if it is present then it is used in make-js-eval-fn to evaluate Javascript source.

arichiardi commented 8 years ago

Hello and thanks a lot for the patch. May I ask what is your use case? Because js.cljs has a way to plug into it an eval function, which replumb overrides. Maybe I can guide you to reach what you want to do?

arichiardi commented 8 years ago

Also another thing is that I'd like you, if you can, check the failing tests as this patch seems to break things. Let me know what I can do in order to help.

arichiardi commented 8 years ago

The test should be easy to fix I think btw

jgrimes commented 8 years ago

I'll check the test when I get a chance! Thanks. I'll document a little more what I'm trying to do in the issue I opened.

arichiardi commented 8 years ago

Hey @jgrimes did you find a workaround for this or it is just paused for now?

arichiardi commented 6 years ago

Closing this for now, feel free to reopen it and thanks!