arichiardi / replumb

ClojureScript plumbing for your self-hosted REPLs.
http://clojurescript.io
Eclipse Public License 1.0
209 stars 16 forks source link

Extensively test ns #62

Closed arichiardi closed 8 years ago

arichiardi commented 8 years ago

Given that it is one of the most important functions and differs a bit from Clojure, it would be great to enhance the tests currently in repl-test.

The ClojureScript's wiki page can be taken as guide.

tomasz-biernacki commented 8 years ago

@arichiardi here I see in the list of ported namespaces clojure.data lein repl

user=> (require 'clojure.data)
nil
user=> (clojure.data/diff '(1 2 3 6) '(3 4 5 6))
[[1 2 3] [3 4 5] [nil nil nil 6]]

lein fig-dev*

cljs.user=> (require 'clojure.data)
nil
cljs.user=>  (clojure.data/diff '(1 2 3 6) '(3 4 5 6))
ERROR - Cannot read property 'diff' of undefined
tomasz-biernacki commented 8 years ago

Also clojure.zip Actually, looking in compiled/out/clojure there are only set string and walk

arichiardi commented 8 years ago

Yes this is normal behavior. We depend on out for demo repls. Actually replumb clients can specify anything in :src-paths so a user can bundle all the libs she wants. We delegate the responsibility to client code. Again, this needs clarification and I will write a wiki page on it.

arichiardi commented 8 years ago

I had a newbie doubt on this but this and this make me think that in :output-dir we have just what we are actually using in our codebase, so in order to have every namespace available we would probably need to bundle it (#69).

arichiardi commented 8 years ago

A bit of a joke, @tomasz-biernacki you chose the only synonym of fix that is not understood by github.

Closed by #75.

tomasz-biernacki commented 8 years ago

True...