arichika / RotativaCore

for ASP.NET Core on Azure Web Apps (by Windows). Support .NETStandard 2.0
https://www.nuget.org/packages/RotativaCore/
MIT License
14 stars 6 forks source link

WriteAsync instead of Write #6

Closed vertonghenb closed 5 years ago

vertonghenb commented 5 years ago

Fixes Synchronous operations are disallowed in ASP.NET Core 3.0.0 #5 No breaking changes, but a follow-up on this fix could be to have the entire process async. for performance reasons.

Tested with ASP.NET Core 2.2 and 3.0.0 (Preview 4)

vertonghenb commented 5 years ago

@arichika can be merged and released if you approve.

arichika commented 5 years ago

@vertonghenb Thank yoy PR. I will confirm immediately and merge, and ship it.