arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.32k stars 3.54k forks source link

Bug: uYou "Disable Auto Caption" breaks CC subtitles completely #451

Open KarmaBeast opened 8 months ago

KarmaBeast commented 8 months ago

Enabling this option prevents subtitles automatically showing all the time, but at the same time prevents the CC button and functionality from working. image

Video link: https://youtu.be/KNexS61fjus?si=Cklsi4g1A_tQM3rX

https://github.com/arichornlover/uYouEnhanced/assets/73917917/63f9d9f5-b31b-49f8-ba5e-3be39fb33ef1

arichornlover commented 8 months ago

It’s literally Disable Auto Caption, I think it completely disables the functionality of the captions so that is unfortunate.

KarmaBeast commented 8 months ago

No I mean it should disable the "Auto" enabling of captions. That's what annoys most people. Especially the Vanced/Revanced community hates it when CC are automatically enabled by YouTube.

It should disable auto-cc and let the user enable/disable it when he wants by tapping the CC button.

Can you fix this tweak?

arichornlover commented 8 months ago

If it’s inside uYou then I would unlikely be able to resolve it.

KarmaBeast commented 8 months ago

Or maybe add your own tweak? Just disable automatically showing captions. This super annoying YouTube behavior. Revanced mods all have this as a feature.

IntelCorei5-8350u commented 8 months ago

Workaround if you still want to disable auto captions (I have this problem for long, since the old days before the existence of this repo) Go to player settings (the cog next to the CC button), select Captions, then turn it off then redo the steps above, but select the CC language you desire this time instead of turning it off

CC should work now.

KarmaBeast commented 8 months ago

I don't get it what are you trying to explain?

I want CC to work just not automatically enabled shown to me. The annoying YT behavior where it automatically shows subtitles on every video.

IntelCorei5-8350u commented 8 months ago

I don't get it what are you trying to explain?

I want CC to work just not automatically enabled shown to me. The annoying YT behavior where it automatically shows subtitles on every video.

https://youtube.com/shorts/jej6CX0Og70?feature=share I screen recorded the steps I do to turn on CC. This is pretty much what I told you to do

KarmaBeast commented 8 months ago

Although I appreciate the effort of creating and posting that video, I don't get it, and I don't want to deal with it to be honest. What you're showing me to do is a major pain in the ass. Cannot expect anyone to follow those steps each time, let alone expect them to understand it.

I hope that this gets fixed, and a tweak gets added to only disable the automatic showing of subtitles, while not breaking subtitles itself.

That way we could turn off the useless broken uYou tweak.

IntelCorei5-8350u commented 8 months ago

It also happens on Revanced (uYou but for Android) every now and then, so I don't think it will be fixed anytime soon. It's not that complicated also. And this is uYou's feature, not uYou enhanced's, so I don't think it's the right place to complain.

On Mon, Mar 18, 2024, 21:06 Karma @.***> wrote:

Although I appreciate the effort of creating and posting that video, I don't get it, and I don't want to deal with it to be honest

I hope that this gets fixed, and a tweak gets added to only disable the automatic showing of subtitles, while not breaking subtitles itself.

That way we could turn off the useless broken uYou tweak.

— Reply to this email directly, view it on GitHub https://github.com/arichornlover/uYouEnhanced/issues/451#issuecomment-2004015216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZCQZNRNNOQON2ZMX3GX3ZDYY3YGLAVCNFSM6AAAAABETFDAXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGAYTKMRRGY . You are receiving this because you commented.Message ID: @.***>

KarmaBeast commented 7 months ago

Who said anything about complaining? I was merely requesting for implementation of seperate uyouenhanced tweak that would only disable the automatic showing of subtitles, but not disable subtitles itself, like the uYou tweak does...

KarmaBeast commented 7 months ago

Also you're wrong on Revanced it works as intended:

image

image

@arichornlover It only disable auto captions. Auto-captions is when subtitles are automatically being forced on and appear on the video. This behavior annoys YouTube users though, as we only want to manually enable subs ourself when we want it. The Revanced mod doesn't fully disable/break the subtitles, like the uYou tweak does.

https://github.com/arichornlover/uYouEnhanced/assets/73917917/72210e28-30a1-4af7-8f06-99a65af306c4

theoccurrence commented 7 months ago

Have you made an issue about this on uYou's Guthub page already? Because I also just noticed this and it's really annoying. Especially because it was me a long time ago which requested the disable automatic subtitles feature from Miro in the first place 😅

KarmaBeast commented 7 months ago

No I don't think I have.

The uYou feature is just broken. It disables the subtitles functionality completely, instead of merely only preventing auto-subtitles from showing when starting a video.

The latter is what the Revanced feature does. Only prevent automatically enabling of subtitles. Its the stock YouTube behavior and massively annoying.

I'm not sure if anyone cares to fix it, and implement a uyouenhanced tweak instead.

theoccurrence commented 7 months ago

Yes, it really is annoying. Luckily, I usually don't need subtitles, so this issue doesn't really impact me personally that much, but I get it.

YouTube also started defaulting to the weirdest audio languages, apparently that's a thing now. I noticed this on a Mark Rober video, I think it always wanted to default to arab. Another video (I can't remember who) defaulted to hindi. Both cases were dubbed and not the original audio.

I might have to make another feature request for that, but I'm not sure if it still happens.