search

arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.26k stars 3.3k forks source link

Display video quality of Shorts! #631

Open KarmaBeast opened 5 months ago

KarmaBeast commented 5 months ago

Shorts which are up to 4K quality are missing their quality indicator when viewed in their Shorts format.

Example: (Can only check through three dot menu) image

No quality button/indicator: image

Quality button is visible when viewing the Short as normal vertical video: (only possible when the Short is added to a playlist, and opened from that playlist) image

KarmaBeast commented 5 months ago

Video link: https://youtu.be/ltV0TJ4oF3M?si=3WqcUdSROXxtlS0V

yodaluca23 commented 5 months ago

Video link: https://youtu.be/ltV0TJ4oF3M

image

KarmaBeast commented 5 months ago

Stop bothering me with such unrelated stuff please. I don't care about this, don't force it on me, or others.

arichornlover commented 5 months ago

Stop bothering me with such unrelated stuff please. I don't care about this, don't force it on me, or others.

It is necessary. It could be bad to have the ?si=%@ in it.

arichornlover commented 5 months ago

Video link: https://youtu.be/ltV0TJ4oF3M

image

https://github.com/arichornlover/uYouEnhanced/commit/83a98ae62689abacd3967abbddc8e19e5c844a3c

arichornlover commented 5 months ago

Shorts which are up to 4K quality are missing their quality indicator when viewed in their Shorts format.

Example: (Can only check through three dot menu) image

Go to A/B Settings and search the word Shorts, and find anything that is related to the QualityPicker, etc.

KarmaBeast commented 5 months ago

Ohh I really don't want to mess with AB settings at all. I was wondering if we can implement this to the app?

Have an option to display the quality button on Shorts format

arichornlover commented 5 months ago

Ohh I really don't want to mess with AB settings at all. I was wondering if we can implement this to the app?

Have an option to display the quality button on Shorts format

Alright 👍

arichornlover commented 5 months ago

Closed because it’s been added!

KarmaBeast commented 5 months ago

Very nice! Looking forward to seeing it soon!

Do you have a screenshot of how it looks? 🙏🏻

(Shorts always play with their highest available quality 4K60FPS like chosen in uYou Quality settings aswell? Right?)

With this request I just wanted to immediately see the Quality in which each Short is playing at. Like with normal videos the Quality button showing. Therefore I'm not sure the name "Quality picker" fits at all. Maybe name it differently like "Short Quality" ?

arichornlover commented 5 months ago

Very nice! Looking forward to seeing it soon!

Do you have a screenshot of how it looks? 🙏🏻

(Shorts always play with their highest available quality 4K60FPS like chosen in uYou Quality settings aswell? Right?)

With this request I just wanted to immediately see the Quality in which each Short is playing at. Like with normal videos the Quality button showing. Therefore I'm not sure the name "Quality picker" fits at all. Maybe name it differently like "Short Quality" ?

IMG_1768 also I plan on limiting this option to specific YouTube Versions just like what I did to LowContrastMode & Fake Premium because once again, the Shorts Quality Picker doesn’t work in older releases of the app

KarmaBeast commented 5 months ago

I think you entirely misunderstood my request? I wanted a quality display just like on normal videos, the quality button.

image

I want to immediately be able to see and know each Shorts video quality. Just like Post Title is saying "Display Video quality of Shorts"

In your screenshot the current quality display is hidden behind three dot menu? This is already possible btw. (First screenshot at the top)

arichornlover commented 5 months ago

I think you entirely misunderstood my request? I wanted a quality display just like on normal videos, the quality button.

image

I want to immediately be able to see and know each Shorts video quality. Just like Post Title is saying "Display Video quality of Shorts"

In your screenshot the current quality display is hidden behind three dot menu?

Oh. You wanted that type of Implementation? Whoops. I never known you meant that type of implementation 😅 so you want me to do another option for that button. It is possible since YouQuality exists.

KarmaBeast commented 5 months ago

Yes LOL! 😂

What you implemented already is a thing. Look at the first screenshot at the top. You can already check video quality thru the three dot menu.

What I asked for is YouQuality/Quality button on Shorts. So that we can immediately see the Shorts video quality, just like when opening normal videos.

arichornlover commented 5 months ago

I’ll see if I could port YouQuality to Shorts.

KarmaBeast commented 5 months ago

In the meantime could you perhaps reopen this post?