ariebovenberg / whenever

⏰ Sensible and typesafe datetimes for Python

https://whenever.rtfd.io

MIT License

361 stars 7 forks source link

Rust extension module #101

Open ariebovenberg opened 3 months ago

ariebovenberg commented 3 months ago

Description

Checklist

[x] Build runs successfully
[x] Docs updated

Release checklist (maintainers only)

[x] Version updated in pyproject.toml
[x] Version updated in src/whenever/__init__.py
[x] Version updated in changelog
[ ] Branch merged
[ ] Tag created and pushed
[ ] Published
[ ] Github release created

ariebovenberg commented 2 months ago

@JaykeMeijer I've taken a first stab at (the basics of) a Date class, have a look 👀

JaykeMeijer commented 2 months ago

@JaykeMeijer I've taken a first stab at (the basics of) a Date class, have a look 👀

Slowly starting to look at this, big learning curve ahead with the Python/Rust integration so might take me some time to get to useful comments. First feedback though is that the installation and setup is a very smooth process, so well done on that!

ariebovenberg commented 2 months ago

@JaykeMeijer note that this PR is a bit in a messy state. One important note is (for now) you need to clone pyo3 repo alongside it and make a small change. This is due to a potential bug (see https://github.com/PyO3/pyo3/issues/4093)