consider renaming 'naive()' to 'as_naive()'

[bxparks]

A very minor observation, but other conversion functions have the form:

• as_utc()
• as_offset
• as_zoned()
• as_local()

But conversion to NiaveDateTime is:

• naive()

Consider changing this to as_naive() for consistency.

[ariebovenberg]

This is intentional (for now 😉 ). Quoting from the docs:

The seemingly inconsistent naming of naive() and the as* methods is intentional. The as* methods preserve the same moment in time, while naive() converts to something else entirely.

[ariebovenberg]

I'll admit that a small "note" block is probably not enough to make this clear. Perhaps a diagram like this (hopefully simplified):

[bxparks]

Ah, I missed the note. The diagram definitely helps. Though I think of the other "as_xxx()" as "losing information" as well. They do preserve "timestamp()", but they lose other information.

[ariebovenberg]

Correct, "losing information" is not the right wording. "loses position on the timeline" is perhaps the best way to describe naive() in comparison to methods like as_zoned()

[ariebovenberg]

I've created a follow-up for visualizing classes and their conversions. This includes rationale for the seemingly inconsistent naming. See #69.

The current issue is about the specific method, which will not be changed. Closed.