search

ariefrahmansyah / remembergaza

🍉
https://remembergaza.id
MIT License
16 stars 6 forks source link

Birthday list #3

Open ariefrahmansyah opened 7 months ago

ariefrahmansyah commented 7 months ago

The dataset that we are using has the date of birth field. Using this data, we can display the victims having birthdays on today's date.

AsadSaleh commented 7 months ago

Interesting, I'll see what I can do. Elixir is new to me.

ariefrahmansyah commented 7 months ago

Interesting, I'll see what I can do. Elixir is new to me.

Thanks, mas! Let me know if you face any trouble running the web server.

Btw, Elixir is also new to me, so please not be surprised with how I wrote the code 😅

AsadSaleh commented 7 months ago

I think I misunderstood what you wanted earlier.

Could you please elaborate on what you want? Is it to have a separate list on the victims that should have a birthday today?

I merely assume you wanted to display the victim's age, that's why I created this pr.

ariefrahmansyah commented 7 months ago

My initial intention was to have a separate UI component that lists victims having birthdays on a given date. Think of it like Facebook's Friends Birthdays. This is one way that I think can help us preserve their lives and memories, by celebrating their birthday.

I'm still not sure about the copywriting here, what I have right now is something like this:

As for your PR, I've seen it and I would like to merge it because it aligns with the UI design in Figma where it displays the age of the victims. Cc: @randyvarianda

image