search

arieh / HistoryManager

a mootools history-manager / obeserver class
18 stars 4 forks source link

Proper Credits? #1

Closed digitarald closed 14 years ago

digitarald commented 14 years ago

If this plugin is mostly based on somebody else's work, you should provide a proper credit/copyright. Just a friendly hint of a sad developer.

arieh commented 14 years ago

I would be happy if you would mention what is the proper way in your opinion. i'm very unfarmilliar with all this buisness. i tried giving credit in the README. if this is not enough i would be glad to add whatever affiliation you see fit. also, the reuse of the name is unintentional (i was using this name before i became acknowledged with your plugin) and if it troubles you i would be happy to change it as well. as i mentioned in the README, this current implementation of the class is mostly a port of your to Moo 1.2, wrapped with a different interface. in no way was i trying to take creit for work not my own, and if in any way this is the implied impression i would be glad to hear of ways to fix this.

digitarald commented 14 years ago

No worries. I am working on moving my History plugin to github, so I can add it to the forge. Maybe we can combine the repositories, so we have my old version for 1.11, your 1.2 version and my totally refactored 1.2 update.

Sorry if I sounded rude, I did not see the mentioned base work in the README. Thanks for releasing this updated version, I saw some people use it.