search

arielfaur / ionic-wizard

A set of angular directives to create a wizard using Ionic's slide box
http://arielfaur.github.io/ionic-wizard
MIT License
81 stars 26 forks source link

Step Action #18

Open genepaul opened 8 years ago

genepaul commented 8 years ago

First of all, thanks for providing this project, it has been of great use to me!

I found some use for having an action that just runs as soon as you navigate to a step, so I thought I'd contribute it back. If you don't think it's good to have in the base component, I'm good with that, but just wanted to provide the option.

This could be used to fetch data when a step is loaded. I suppose the user could listen for wizard:Next or slideBox.slideChanged, but this integrates it into the component more declaratively.

timemachine3030 commented 7 years ago

This is a great patch, I too need an 'on display' function call.

genepaul commented 7 years ago

@timemachine3030 - it appears this repo is not actively maintained. Feel free to fork my fork. Mine may be out of date currently, but if you're interested in using it, I can make the effort to get it back in line with master.

arielfaur commented 7 years ago

Hi @genepaul ! Sorry for the delay. You are right, i am not maintaining this repo (I have moved on to Ionic 2). If you want, I can add you to this repo if you want to do the merge.

genepaul commented 7 years ago

I'd be happy to maintain this, as I am using it in a project of my own that isn't looking to upgrade to Ionic 2 yet. Curious - will you be creating something like this for Ionic 2 as well? I haven't looked at it too extensively.

arielfaur commented 7 years ago

@genepaul I've just added you to the repo as collaborator 😄

arielfaur commented 7 years ago

I am not so sure whether it makes sense to create a module like this one for Ionic 2 since it seems easier to implement a wizard from scratch