search

arielhr1987 / leira-letter-avatar

Wordpress plugin to set letter avatars to users
GNU General Public License v2.0
4 stars 3 forks source link

Fatal Error in Admin Console with latest ClassicPress (1.2) #1

Open InkyQuill opened 3 years ago

InkyQuill commented 3 years ago

ClassicPress is a fork of Wordpress based on WP 4.9. Your plugin states it is compatible with WP 4.7+, so it should work, but in practice it shows a fatal error: Call to undefined function is_avatar_comment_type()

I have found a workaround, mentioned in the following issue: ClassicPress/ClassicPress-v1#92 Opened this to notify you about that issue 'cause it is relevant to your project.

arielhr1987 commented 3 years ago

Hi @InkyQuill

Looks like I am going to need to update plugin compatibility version to 5.1. As the method you mention was introduced in wordpress 5.1. Thanks for letting me know about it, I appreciate it.

timbocode commented 3 years ago

Is is_avatar_comment_type essential to the operation of Letter Avatar? And could you not do something like this:

if wp < 5.0 then do_something()
else is_avatar_comment_type()

The reason I ask is not just because this would maintain compatibility with ClassicPress but also because it would maintain compatibility with WordPress 4.9. Even now, approximately 20% of WP users are still on version 4.9 or less, so that's potentially a sizeable group of users who will no longer be able to use your plugin.

arielhr1987 commented 3 years ago

I think I can do that. I will try to release a fully compatible version with wp 4.9

timbocode commented 3 years ago

Excellent. That would be great.

Thank you. 👍🏻

arielhr1987 commented 3 years ago

Hi guys Leira Letter Avatar version 1.3.2 has been release. I tested with WP 4.9 and work very well. Let me know if you experience any other issue.

nylen commented 3 years ago

Thanks for fixing this.

The plugin page on WordPress.org still says "WordPress Version: 4.7 or higher". You should either update this to say "4.9 or higher" or test with WP 4.7 and confirm that it still works there.

In any case the issue reported with WP 4.9 and therefore ClassicPress looks like it should be fixed now.