arielmol / dviz

Automatically exported from code.google.com/p/dviz
0 stars 0 forks source link

Changing Groups while 'Clear' is Active does not Cross-Fade #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
- Send a group to the output and some text. Click clear, verify clear is
active (just BG showing on output now.)
- Send a different group to the output with a different background (so you
can see any change in BG)
- It doesn't cross fade to new BG, just "cuts"

Original issue reported on code.google.com by josiahbryan@gmail.com on 23 Jan 2010 at 5:04

GoogleCodeExporter commented 8 years ago
Caused by an errant connection in SlideGroupFactory.cpp/SlideGroupListControl 
to the
selection model's currentChanged(const QModelIndex &, const QModelIndex &) 
signal -
which was disconnected by changing to sel-model in the song slide group view 
control.
This extra connection caused the slide to be set twice upon going live - this 
caused
the clear cross fade to jump to the end of the transition prematurely. 

Original comment by josiahbryan@gmail.com on 24 Jan 2010 at 10:05

GoogleCodeExporter commented 8 years ago
Re-opening issue because the issue has re-appears.

Original comment by josiahbryan@gmail.com on 16 Feb 2010 at 12:04

GoogleCodeExporter commented 8 years ago
Fixed in r481. 
Quoting Comment from MainWindow.cpp:

I think I've coded my own API under an incorrect assumption - that is, that I 
need to
set the slide group on the instance instead of just letting the 
SlideGroupViewControl
set the slide group - which now seems the more logical method. Therefore, I've
removed direct calls to OutputInstance::setSlideGroup() from MainWindow::* 
methods,
and instead will rely on SlideGroupViewControl to set the slide group on the
outpuTInstance that it is responsible for managing.

Original comment by josiahbryan@gmail.com on 16 Feb 2010 at 3:50

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r481.

Original comment by josiahbryan@gmail.com on 16 Feb 2010 at 4:02

GoogleCodeExporter commented 8 years ago
Also had to adjust SlideGroupViewControl to not duplicate calls to
'm_slideViewer->setSlide(s)' - in ::setCurrentSlide, it called
'm_slideViewer->setSlide(s)', then called slideSelected() with a QModelIndex.
slideSelected() then in turn called m_slideViewer->setSlide(s) again with the 
slide
for that index. 

Just FYI.

Original comment by josiahbryan@gmail.com on 16 Feb 2010 at 4:03