REM vs px, incompatible with bootstrap 4

arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js

https://vueds.com

MIT License

2.17k stars 224 forks source link

Closed chenchenalex closed 5 years ago

chenchenalex commented 5 years ago

Hi, I am running into an issue that I tried to integrate bootstrap 4 into vueds, but this error pops up:

$input-height-inner: ($font-size-base $input-btn-line-height) + ($input-btn-padding-y 2) !default; Incompatible units: 'rem' and 'px'.

$font-size-base is 16px while bootstrap has replaced 16px to 1rem, any ideas on solving this one? thanks!

chenchenalex commented 5 years ago

Found one solution: change the value in font-size.yml to 1rem can solve the conflicts issue

arielsalminen commented 5 years ago

@chenchenalex Great!