search

arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js
https://vueds.com
MIT License
2.17k stars 224 forks source link

SvgIcon component does not work in IE11 #114

Closed sdellis closed 5 years ago

sdellis commented 5 years ago

I'm not sure what the browser support for VueDS is, but the SvgIcons do not work in ie11 because ie11 does not support innerHTML on svg elements.

I tried to use the innersvg-polyfill, but it does not seem to be working (even in plain HTML without Vue).

I'm able to get it working using img tags with the svg as the src, but that means that icons cannot be filled dynamically with the fill prop.

sdellis commented 5 years ago

This approach works in IE11. It will also be helpful for codesplitting/treeshaking steps discussed in #111 since the icons become components that are "imported" rather than "loaded".

arielsalminen commented 5 years ago

This has been fixed now in the latest 3.1.0 release.