arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js
https://vueds.com
MIT License
2.17k stars 225 forks source link

Use vue cli 3 to set up the various webpack configurations #127

Closed elevatebart closed 1 year ago

elevatebart commented 5 years ago

Feature branch for #83

arielsalminen commented 5 years ago

@elevatebart I’ll try to find time to look into this later this week! Been away from computer for a week or so and haven’t had a chance yet to take a closer look.

HerrBertling commented 5 years ago

Quick thought: This already touches 34 files and has quite some tasks still open. Could it be easier (also to review) to do these step by step? The tasks seem rather unrelated to me, so maybe do it step by step? :)

arielsalminen commented 5 years ago

@elevatebart do you have thoughts regarding @HerrBertling’s comment? Personally don’t see it as a problem if this is one separate big branch as it might be quite hard to do these things in isolation from each other. Also don’t think any of these things could be merged in separately…?

elevatebart commented 5 years ago

@viljamis, @HerrBertling I think it might be a grand idea, I just need to revert the switch to yarn since it is not necessary for this change. Let me revert yarn and then you can merge.

...Unless of course if @viljamis you are confortable with switching to yarn.

elevatebart commented 5 years ago

Hi @viljamis, I removed entirely the references to yarn from this branch. I hope yuou find the comments here useful. If not please advise.

Yours, bart

arielsalminen commented 5 years ago

@elevatebart I will review thoroughly the new set of changes soon!

ufoscout commented 5 years ago

Any news on this? I guess this could also ease the integration with typescript