search

arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js
https://vueds.com
MIT License
2.17k stars 225 forks source link

Using vue-design-system in lerna with @vue/cli-service installed #148

Open tenosiswono opened 5 years ago

tenosiswono commented 5 years ago

I'm trying to make some multi-package project using Lerna with vue-design-system and @vue/cli-service installed. The vue-cli is used in root project not in vueds project. However in vue-styleguidist has some existsVueCLI function that lead to TypeError: Cannot read property 'filter' of undefined error. I can't find the option in Lerna that can ignore the require('@vue/cli-service/package.json'); function in vue-styleguidist. Is it any option in vue-design-system that can disable the existsVueCLI checking? thanks. 👍

elevatebart commented 5 years ago

@viljamis , I believe my PR #127 would solve this. What do you think?

tenosiswono commented 5 years ago

@elevatebart I just tried using your branch, and it's works! Thanks a lot. I hope your PR will be merged for this issue

arielsalminen commented 5 years ago

@elevatebart I think so too. I will find time early next week or during the weekend to review everything you’ve done so far! :)