arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js
https://vueds.com
MIT License
2.17k stars 223 forks source link

Why is <Icon> component from /src/elements/ referenced in /docs/components/status/Components.vue? #197

Open pmpinto opened 4 years ago

pmpinto commented 4 years ago

My point is that, from what I understand about VueDS, /src/elements/ is where we're supposed to build our own components.

And /docs/components/status/Components.vue is part of VueDS itself.

Isn't it weird that <Icon>, as a component that is sitting in a folder that I will eventually change for my own needs, is also being referenced by VueDS itself? What if I don't need an <Icon> component? If I just delete the file, VueDS will ask for it.

In my case, I actually needed an <Icon> component but not exactly like how it's built by default. So I changed it. And then went to /#/Elements and to my surprised my <Icon> component was now part of VueDS's UI.

Is it just me that finds this weird? Same for /src/assets/icons. I can't just remove them since VueDS will need these icons. I have to move these manually somewhere else where VueDS might reach out to and not compromise my own components.