search

arielsalminen / vue-design-system

An open source tool for building UI Design Systems with Vue.js
https://vueds.com
MIT License
2.17k stars 224 forks source link

Example not working in Safari #65

Closed rothsandro closed 6 years ago

rothsandro commented 6 years ago

The example is not working in Safari 10.0.3 on OS X 10.11.6:

SyntaxError: Cannot declare a let variable twice: 'e'.
arielsalminen commented 6 years ago

@rothsandro Thanks for reporting this! The living docs only supports the few latest versions of Safari (see https://github.com/viljamis/vue-design-system/wiki/frequently-asked-questions-(FAQ)#what-browsers-are-supported for browser support), and I’m guessing that is related to Safari 10’s bug with let variables: https://caniuse.com/#feat=let

I will see if there’s an easy way to fix this though as 10 isn’t that old.

arielsalminen commented 6 years ago

@rothsandro I think this is related to: https://github.com/vue-styleguidist/vue-styleguidist/issues/83

rothsandro commented 6 years ago

Yes, seems to be related. The last time I used Vue Styleguidist, the production build was not working in Safari.

arielsalminen commented 6 years ago

Looking into this now and hoping it will get fixed in https://github.com/viljamis/vue-design-system/pull/82

arielsalminen commented 6 years ago

@rothsandro looks like it’s working now. I do get a warning in console which is caused by something in Styleguidist, but at least everything’s working and it’s completely usable.

arielsalminen commented 6 years ago

(I haven’t published this fix yet though)

arielsalminen commented 6 years ago

Released in https://github.com/viljamis/vue-design-system/releases/tag/3.0.0