search

aries-auto / ariesautomotive

Aries Automotive Website
MIT License
1 stars 3 forks source link

Application Guides - Luverne #236

Closed ninnemana closed 7 years ago

ninnemana commented 7 years ago

Currently there is no application guide section for Luverne like ARIES: http://ariesautomotive.com/appguides.

@1brandeja5 has populated Finish as a product attribute for all Luverne items, so we can pivot out application data onto an application table. There are two adjustments that will have to be made:

  1. Luverne app data is in year/make/model/body/fuel/cab/box format.
  2. There is no Godzilla (flat collection) data structure, so we'll have to pull the application data directly off the product collection and aggregate it into groups using the category hierarchy.
davidvthecoder commented 7 years ago

An update to the progress of this issue can be seen here: http://luverne-appguides-dot-luverne-truck.appspot.com/appguides

Things left to do:

  1. Fix/Replace Category Images @aaronrodgersmoustache mind helping me with this?
1brandeja5 commented 7 years ago

We are shooting for December 23 to have excel/pdf downloads available that are generated from the same data and formatted to graphics/marketing needs.

davidvthecoder commented 7 years ago

Unit tests have been added, link has been added, and some padding to the table has also been added.

1 image is broken, while another image is missing. I will be getting with Tim @aaronrodgersmoustache to update this.

ninnemana commented 7 years ago

Is this ready to be launched? If so, PR plz.

davidvthecoder commented 7 years ago

there are a couple of images that need to be updated before we launch. I got with @aaronrodgersmoustache about the images and he will be updating them shortly.

I will create the PR once those broken/bad images are addressed.

1brandeja5 commented 7 years ago

we should probably have someone from Luverne validate the data, no?

davidvthecoder commented 7 years ago

sure, the data is our product/category/vehicle data that drives our lookup currently, but it doesnt hurt to double check

ninnemana commented 7 years ago

@1brandeja5 are we meeting with luverne anytime soon to get their sign-off?

1brandeja5 commented 7 years ago

whenever you want :)

1brandeja5 commented 7 years ago

Here are the first 3 approved app guides Tuff Guard 3 IN Van Bumper Guards.xlsx Prowler Max Grille Guards.xlsx Tow Guards and Heat Shields.xlsx

ninnemana commented 7 years ago

Looks like the 6 1/2" running board breaks the URL routing: http://localhost:3000/appguides/363/MegaStep%206%201/2%22%20Running%20Boards

1brandeja5 commented 7 years ago

Is that why it ended up being 6.5 Inch before?

dgallegos commented 7 years ago

We are not doing it this way.