search

aries-auto / ariesautomotive

Aries Automotive Website
MIT License
1 stars 3 forks source link

Aries Lookup Models not grouping correctly #266

Closed davidvthecoder closed 7 years ago

davidvthecoder commented 7 years ago

@1brandeja5

There is a sorting issue and a grouping issue. It is not grouping the 2500 HD together and it is sorting the Suburban XL above the Silverado, and then more Suburban choices exist below the Silverado.

image

Looks like there is either a problem in the CSV or a problem with the upload/read process.

davidvthecoder commented 7 years ago

I found the source of the duplicates / not grouping together. Pushing up a fix for it right now.

@1brandeja5 The Sort Order is a different problem. In the CSV and in the Data all of the Suburban's are Title cased. The Suburban XL however is all uppercase. All Uppercase will be sorted alphabetically before the Title Case. In order to convert all uppercase into title case, I have to convert it to lower first, then to title. I can do this but then you run into the problem of turning things like Silverado 1500 HD to Silverado 1500 Hd.

davidvthecoder commented 7 years ago

The Website itself converts everything into all Uppercase for showing on the website, but anyone that consumes our data from our API will have the different casing.

davidvthecoder commented 7 years ago

I am going to reccomend that we sort them on AriesAutomotive.Com rather than through the API. I will work on implementing that fix.

davidvthecoder commented 7 years ago

I removed the duplicates, and the sort order is now working propperly:

screen shot 2017-02-06 at 11 31 21 am