search

ariesteam / aries

http://www.ariesonline.org
GNU General Public License v3.0
6 stars 1 forks source link

incorrect syntax on gray infrastructure sink? #54

Closed kbagstad closed 12 years ago

kbagstad commented 12 years ago

@lambdatronic

Checking the Puget flood sink models, and for some reason they don't seem to properly be adding detention basin and dam storage together to produce gray infrastructure storage. Try:

model -o floodsink2 core.models.flood-puget/gray-infrastructure-sink core.contexts.puget/puget2048

This should give you some isolated detention basins, with values of 3000 mm, and some dam storage values. But when you look at the gray infrastructure output, which is supposed to sum the two, you'll see places where there are detention basins but the supposedly summed value is zero. Further, if you look at unique values of gray infrastructure storage and dam storage, they're identical (there are no values of "3000" for gray infrastructure storage. So detention basins are being wrongly ignored. I'd imagine this must be a simple syntax issue...

lambdatronic commented 12 years ago

You were right that this was a trivial syntax issue. You just mislabeled the context reference in the :state function. It should have been :detention-basin-storage, not :detention-basin. I fixed and pushed the change.

kbagstad commented 12 years ago

Thanks g-man. I'll give it a closer look, that should let me get the Puget flood models running.

Ken

On Wed, Feb 15, 2012 at 11:28 AM, Gary Johnson reply@reply.github.com wrote:

You were right that this was a trivial syntax issue. You just mislabeled the context reference in the :state function. It should have been :detention-basin-storage, not :detention-basin. I fixed and pushed the change.

Reply to this email directly or view it on GitHub: https://github.com/ariesteam/aries/issues/54#issuecomment-3985929