search

ariestwn / alfred-natural-calendar

MIT License
7 stars 0 forks source link

Do not store `calendar_profile.log` in workflow folder #2

Open chrisgrieser opened 16 hours ago

chrisgrieser commented 16 hours ago

Right now, the log calendar_profile.log is stored in the workflow folder. Log data should not be stored in the workflow folder itself, but rather inalfred_workflow_cache or alfred_workflow_data (accessible as environment variables from inside Alfred).

Also, the current release contains a calendar_profile.log from when you used the workflow. It contains a bunch of information that looks like your personal calendar usage, and some of the data look as if they were potentially private, so I'd even consider deleting the 1.0.0 release if those logs contain private data of yours?

ariestwn commented 8 hours ago

@chrisgrieser Wow, thanks for the feedback! It seems I missed something in the package creation script. For now, I will change it to alfred_workflow_data for the calendar_config.json and the log, and later I will update the log in alfred_workflow_cache. I would appreciate any additional feedback you have on the current issue.

chrisgrieser commented 7 hours ago

Simply moving those should be fine.

Though putting config data into the data folder is tricky, since it then went sync if the user syncs their config. I think simply selecting a default calendar via Alfred config might make most sense?