arifkla / tea-cozy

0 stars 0 forks source link

SUMMARY #5

Open ad3429 opened 6 years ago

ad3429 commented 6 years ago

Summary Grade: Satisfactory

Good job! Your files are organized nicely, and you did a great job of matching the client specification for the most part -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed excellent code practice, so make sure to keep that up!

I have made some comments in your code to take note of. First off, great job making sure to comment the main parts of your HTML and CSS. This is something that many learners forget to do, but it goes a long way, especially as your projects grow and become more complex.

Your code is very nicely structured/formatted and follows excellent code practices such as readability, indentation, etc. Overall, you did an excellent job.

This isn't a big issue now since you haven't learned about this yet, but I wanted to introduce you to the idea of responsive design. You will certainly learn more about this concept in the next project, but I wanted to provide a great resource to get you to start thinking about building sites that look good on all different kinds of platforms/browser sizes:

https://www.w3schools.com/css/css_responsive_intro.asp

Great job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs.)

arifkla commented 6 years ago

i did not expect that i can get satisfactory grade in my first trial in this tea cozy project. Before i got this review, i am really not confident with my code,, i thought there will be many of mistake in my code, but now,, you are raisen my confident to do challenge myself even more to have complex coding.

Thank you.