Theme Changer Accesibility Tweaks

arifszn / gitprofile

🚀 Create and deploy a dynamic portfolio by just providing your GitHub username.

https://arifszn.github.io/gitprofile

MIT License

1.64k stars 1.56k forks source link

Theme Changer Accesibility Tweaks #594

Closed Ekatwikz closed 3 months ago

Ekatwikz commented 4 months ago

theme changer: improve tabbability indexed each theme's anchor tag, for easier keyboard navigation
theme changer: moved prevent default call
theme changer: add handler for Enter keypress allows changing themes using keyboard only,
would probably improve accisibility

arifszn commented 4 months ago

Not working for me. When I press the keyboard down key, the whole page scrolls.

Ekatwikz commented 4 months ago

The changes were to allow the tabbing order to include the themes, and to allow themes to be selected using the Enter key You can test the changes by repeatedly pressing Tab (or Shift+Tab to go backwards) until you reach some theme, then press Enter to select that theme

arifszn commented 3 months ago

Sorry, we don't have plan for this.