search

arihantjain97 / pe

0 stars 0 forks source link

Edit command: Editing tags not being cumulative #8

Open arihantjain97 opened 3 years ago

arihantjain97 commented 3 years ago

It is explained in UG that tags are cleared once edited. However, the way tags are intended to operated in this app is to allow for patient history/condition to be recorded for appointment purposes. But, if patients experience additional conditions, there is no way to add on a tag without losing the existing ones first.

Unless there is another way to save patient conditions, edit-tag should serve to either edit a specified tag or add a new tag on

Steps to reproduce 1) use edit-patient command 2) after typing command, edit index 2, tags t/newcondition

Expected the tag: [newcondition] is added on to existing tags

Actual all previous tags are cleared, tag: [newcondition] is the only one added

Screenshots

tag edit.PNG

nus-pe-bot commented 3 years ago

Team's Response

Current implementation is more convenient and reasonable. If the patient's condition was entered wrongly previously, accumulative tag addition will result in great inconvenience, because we want to change (edit) it. Edit is intend to "change", not "add".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello, Thank you for the response.

I refer to your reasoning for the rejection, especially this line: "Edit is intend to “change”, not “add”. "

Yes, i understand that edit should modify and not add. However, looking as you can add as many tags as possible to your patients, and given that the tags are used to contain sensitive information about the patients. There is no way to edit them without losing all of those multiple tags.

This reasoning of "change" not "add" makes sense if you have one singular tag. Then if it were to be changed, then the entire tag can be replaced with something new.

However, you have given a option of have multiple tags. You have shown that they each are to be used to store unique patient information. But you have not given a proper way to edit any of them.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This is a flaw that causes occasional inconvenience to clerks/nurses who wish to edit patient information. They can continue to use the product.

This is not a rare situation, as clerks/nurses would be using the tag feature for patients.