fix: blank iframe issue

arikchakma / maily.to

Craft beautiful emails effortlessly with Maily, the powerful email editor that ensures impeccable communication across all major clients.

https://maily.to

MIT License

1.44k stars 74 forks source link

fix: blank iframe issue #18

Closed moogii closed 10 months ago

moogii commented 10 months ago

Description

fixes #15 iframe onLoad isn't working

What

set inner html in useeffect hook

vercel[bot] commented 10 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @arikchakma on Vercel.

@arikchakma first needs to authorize it.

arikchakma commented 10 months ago

Can you please add a before and after? I'm curious why setTimeout of 200ms. Why not directly use the useEffect hooks?

moogii commented 10 months ago

Before

After

As for setTimeout, I have made mistake.

arikchakma commented 10 months ago

@moogii Thanks for the PR.

Can you please test it with other browsers, I've used this approach before. It wasn't working. For me, my current solution is working on every browser. Maybe as the #15 issue mentioned, it was happening because of an extension.

moogii commented 10 months ago

I read all comments on #15. Maily isn't working on Chrome (Version 118.0.5993.117 (Official Build) (arm64)), Safari (Version 17.0 (19616.1.27.211.1)) and Brave. Even after disabling extensions, iframe was blank, also I haven't installed any extensions on Safari. After digging around I found that iframe is not consistent through browsers and OSs.

arikchakma commented 10 months ago

It's not working in Firefox.

moogii commented 10 months ago

Interesting. Maily preview is working properly in Firefox. Now my solution is working in Firefox.

arikchakma commented 10 months ago

Check my changes, it will work now work on Safari and Firefox properly.