search

arikchakma / maily.to

Craft beautiful emails effortlessly with Maily, the powerful email editor that ensures impeccable communication across all major clients.
https://maily.to
MIT License
1.44k stars 74 forks source link

Add image resize extension #24

Closed wwayne closed 8 months ago

wwayne commented 8 months ago

Hi, sorry I only tested in my own repo, not sure if any CI works need to be added to this PR. I also update the tailwind config so that the align-center can has an accurated position.

Result: 2023-12-17 15 08 29

vercel[bot] commented 8 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @arikchakma on Vercel.

@arikchakma first needs to authorize it.

arikchakma commented 8 months ago

@wwayne Thanks for the PR, it's a nice feature. I'll check it out soon.

wwayne commented 8 months ago

@arikchakma thanks, no worries : ) I didn't check the coding format of the original project Plz feel free to close this PR and add your own version if it would save your time

arikchakma commented 8 months ago

@wwayne No worries, The code seems fine to me. I'm just busy with some internal work, I'll check it and make some changes whenever I get time. Again Thanks for the PR man.

arikchakma commented 8 months ago

@wwayne Hey man, unfortunately, it's not working for me. Would you mind assisting me, please?

image
arikchakma commented 8 months ago

@wwayne What do you think if we use this solution maybe?

wwayne commented 8 months ago

oh no : ( , I will take a try when I have time. I'm not sure the solution you mentioned, but if it works then we can close this PR can use that one haha

arikchakma commented 8 months ago

Maybe it's because of the inline logo that I've? I'm not able to message you on twitter, mind pinging me there?

arikchakma commented 8 months ago

@wwayne Hey man I'm able to make it work. I'll make some tweaks and merge it, thanks, man.

wwayne commented 8 months ago

Cool good to know that : )

wwayne commented 8 months ago

I found after adding this image-resize extension, when dragging the image to another place, you can see the blurred image placeholder is in a incorrect position. I will take a close look when i have time, and I was thinking maybe the solution you mentioned above https://github.com/steven-tey/novel/blob/main/packages/core/src/ui/editor/extensions/image-resizer.tsx is better, will take a try as well

arikchakma commented 8 months ago

But I don't see it, I've been fixing some from it. I'm almost done.

arikchakma commented 8 months ago

@wwayne I move this into #25 here, please let me know what you think. I've added some edge cases like preventing from scaling more than the container.