search

arikrupnik / the-heir

He's running from responsibility. She's saving the world. They have thirty days to deal with what their families left in store for them
GNU General Public License v3.0
4 stars 2 forks source link

Victoria valentine patch 1 #49

Open VictoriaValentine opened 6 years ago

VictoriaValentine commented 6 years ago

Lol is this what I'm supposed to do...?

arikrupnik commented 6 years ago

There is a lot here, and some parts of it is easier for me to follow than others. The generic commit messages and a a missing PR description make it harder to unpack the changes you're proposing.

In general, it is a lot easier to handle pull requests when they cover single issues. For instance, "Adding photos of Penny's wardrobe" is an easy, atomic PR to review and merge. "Adding 3 scenes between Penny and Candy" is an easy RP to review and merge.

I propose that we meet and go over the changes you're proposing one by one to untangle all the different improvements you're making.

VictoriaValentine commented 6 years ago

Ok, that sounds good to me, what is your availability tomorrow?

On Fri, Jul 27, 2018 at 7:12 PM, arikrupnik notifications@github.com wrote:

There is a lot here, and some parts of it is easier for me to follow than others. The generic commit messages and a a missing PR description make it harder to unpack the changes you're proposing.

In general, it is a lot easier to handle pull requests when they cover single issues. For instance, "Adding photos of Penny's wardrobe" is an easy, atomic PR to review and merge. "Adding 3 scenes between Penny and Candy" is an easy RP to review and merge.

I propose that we meet and go over the changes you're proposing one by one to untangle all the different improvements you're making.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arikrupnik/the-heir/pull/49#issuecomment-408567494, or mute the thread https://github.com/notifications/unsubscribe-auth/AlZ553-Ln1knJvLbGXN63ywppW56xsWmks5uK6x3gaJpZM4VdJCe .

-- Victoria Valentine EMC Actress Instagram: @msvvalentine_oeuvre vmvalentine.wix.com/theatreartist

arikrupnik commented 6 years ago

I can do 11am, though see my other email. I'd like to tie loose ends regardless.

VictoriaValentine commented 6 years ago

Ok, I can’t meet until the afternoon anyway. I’ve seen it.

On Sun, Jul 29, 2018 at 9:36 PM arikrupnik notifications@github.com wrote:

I can do 11am, though see my other email. I'd like to tie loose ends regardless.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arikrupnik/the-heir/pull/49#issuecomment-408730587, or mute the thread https://github.com/notifications/unsubscribe-auth/AlZ557MoVee3iSwe2IIvmP_Jr7g0jNRlks5uLnFCgaJpZM4VdJCe .

-- Victoria Valentine EMC Actress Instagram: @msvvalentine_oeuvre vmvalentine.wix.com/theatreartist