search

arikrupnik / the-heir

He's running from responsibility. She's saving the world. They have thirty days to deal with what their families left in store for them
GNU General Public License v3.0
4 stars 2 forks source link

Scene files etc. #51

Open VictoriaValentine opened 6 years ago

VictoriaValentine commented 6 years ago

Ari, Would you create a scene file for each character so that new suggestions can be posted? Also I have tried commiting directly to the master, but I am restricted from doing so and end up creating more new branches...mostly by mistake. oops.

arikrupnik commented 6 years ago

Would you create a scene file for each character so that new suggestions can be posted?

Now that we have @DanielWellsDFW working on this, I want to defer to him. So far the structure that I've followed has been to put all scenes with a particular tragic hero into one file and pull them, individually, into the right place in the-heir.fountain. Daniel may have different ideas, I and I want to support him in implementing them.

I have tried commiting directly to the master, but I am restricted from doing so and end up creating more new branches...mostly by mistake. oops.

Indeed, repository settings restrict commits to master. It is fairly easy to merge the different branches you've created back into a single branch. I can make the relevant pull requests for you to approve.

Separately, when you open an issue, you want to clarify completion criteria. For instance, if the issue is that a scene is missing, we can close the issue once we merge that scene. I'm less clear on the completion criteria for this issue. Doe sit need further work, or can we close it?

VictoriaValentine commented 6 years ago

Understood, yes. feel free to close these issues and in the future, I will try to make completion criteria clearer.

On Fri, Jul 27, 2018 at 6:52 PM, arikrupnik notifications@github.com wrote:

Would you create a scene file for each character so that new suggestions can be posted?

Now that we have @DanielWellsDFW https://github.com/DanielWellsDFW working on this, I want to defer to him. So far the structure that I've followed has been to put all scenes with a particular tragic hero into one file and pull them, individually, into the right place in the-heir.fountain. Daniel may have different ideas, I and I want to support him in implementing them.

I have tried commiting directly to the master, but I am restricted from doing so and end up creating more new branches...mostly by mistake. oops.

Indeed, repository settings restrict commits to master. It is fairly easy to merge the different branches you've created back into a single branch. I can make the relevant pull requests for you to approve.

Separately, when you open an issue, you want to clarify completion criteria. For instance, if the issue is that a scene is missing, we can close the issue once we merge that scene. I'm less clear on the completion criteria for this issue. Doe sit need further work, or can we close it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arikrupnik/the-heir/issues/51#issuecomment-408565455, or mute the thread https://github.com/notifications/unsubscribe-auth/AlZ553TdNWQohGz-2gDSSoQ4VqJapE1rks5uK6fUgaJpZM4ViRhE .

-- Victoria Valentine EMC Actress Instagram: @msvvalentine_oeuvre vmvalentine.wix.com/theatreartist