search

arildjensen / cis-puppet

Center for Internet Security Linux Benchmark implementation for PuppetLabs
Other
117 stars 62 forks source link

Adding support for AWS Linux 2014.09 #32

Closed proletaryo closed 9 years ago

proletaryo commented 9 years ago

@arildjensen

Hi there. I'm working on expanding the support of your module to AWS Linux. I'm basing my changes from CIS's benchmark for AWS Linux 2014.09.

This is a work in progress but I'm already done with 1.x.x - 4.x.x. I'm hoping that these changes could be merged back to your master. If you have questions/concerns, please let me know.

arildjensen commented 9 years ago

Can you take a look at the c0001.pp change you did?

$ df --local -P | awk {'if (NR!=1) print \$6'} | xargs -I '{}' find '{}' -xdev -type d \( -perm -0002 -a ! -perm -1000 \) 2>/dev/null | xargs chmod a+t
df: `/sys/kernel/debug'awk: {if (NR!=1) print \$6}
awk:                   ^ backslash not last character on line
proletaryo commented 9 years ago

I have to escape $6, otherwise Puppet will treat it as regular variable. It seems that error is pointing to these lines:

Unrecognised escape sequence '\(' in file /home/travis/build/arildjensen/cis-puppet/manifests/linuxcontrols/c0001.pp at line 16
Unrecognised escape sequence '\)' in file /home/travis/build/arildjensen/cis-puppet/manifests/linuxcontrols/c0001.pp at line 16
Unrecognised escape sequence '\(' in file /home/travis/build/arildjensen/cis-puppet/manifests/linuxcontrols/c0001.pp at line 17
Unrecognised escape sequence '\)' in file /home/travis/build/arildjensen/cis-puppet/manifests/linuxcontrols/c0001.pp at line 17
rake aborted!

These probably needs to be escaped.

proletaryo commented 9 years ago

Finally! build is now successful. I had to fix the formatting of other classes - puppet-lint of the CI is very strict :)