arimorty / floatingsearchview

A search view that implements a floating search bar also known as persistent search
https://github.com/arimorty/floatingsearchview/blob/master/README.md
Apache License 2.0
3.54k stars 667 forks source link

Please update android support libraries #199

Closed shifatul-i closed 7 years ago

shifatul-i commented 7 years ago

currently used

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:23.3.0'
    compile 'com.android.support:recyclerview-v7:23.3.0'
    compile 'com.android.support:design:23.3.0'
    compile 'com.android.support:cardview-v7:23.3.0'
    compile 'com.bartoszlipinski:viewpropertyobjectanimator:1.2.0'
}

Update to

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:25.2.0'
    compile 'com.android.support:recyclerview-v7:25.2.0'
    compile 'com.android.support:design:25.2.0'
    compile 'com.android.support:cardview-v7:25.2.0'
    compile 'com.bartoszlipinski:viewpropertyobjectanimator:1.2.0'
}

Or better, use something like

android {
    compileSdkVersion project.sdk
    buildToolsVersion project.buildTools

    defaultConfig {
        minSdkVersion project.minSdk
        targetSdkVersion project.sdk
        versionCode 10
        versionName "2.0.3"
        //consumerProguardFiles 'consumer-proguard-rules.txt'
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:' + project.supportVersion
    compile 'com.android.support:recyclerview-v7:' + project.supportVersion
    compile 'com.android.support:design:' + project.supportVersion
    compile 'com.android.support:cardview-v7:' + project.supportVersion
    compile 'com.bartoszlipinski:viewpropertyobjectanimator:1.2.0'
}
tmiyamon commented 7 years ago

my workaround is

    compile('com.github.arimorty:floatingsearchview:2.0.3') {
        exclude group: "com.android.support"
    }
shifatul-i commented 7 years ago

thanks for the idea, it should be like

    compile('com.github.arimorty:floatingsearchview:2.0.3', {        
        exclude group: "com.android.support"
    })