search

arimorty / floatingsearchview

A search view that implements a floating search bar also known as persistent search
https://github.com/arimorty/floatingsearchview/blob/master/README.md
Apache License 2.0
3.54k stars 667 forks source link

Dismiss search on touch suggestions list margins #259

Open eduardbosch opened 7 years ago

eduardbosch commented 7 years ago

Hi to all 🎉

I've fixed an issue where touch is propagated below floating search views when it's focused.

The bug

I've checked the issue in the sample app by removing the 5dp margins to the search_results_list in fragment_sliding_search_results_example_fragment.xml. Then you can see that this bug appears:

wrong_scroll

The fix

To avoid this, I've changed the touch listener to dismiss the search from mSuggestionsSection to the FloatingSearchView itself, because it occupies the whole screen.

Now it works well

good_scroll

eduardbosch commented 7 years ago

Added maven library to use jitpack

eduardbosch commented 7 years ago

Updated some missing setEnabled refactoring from mSuggestionsSection to view itself.