I've fixed that if swapSuggestions is called twice in a row, then the suggestions are displayed incorrectly.
The problem
OnGlobalLayoutListener is called twice for single suggestion swap if we call swapSuggestion in the same frame. The problem is that the second time we call swapSuggestion, OnGlobalLayoutListener has still not being called, so it ends up calling it twice (or many times).
The solution
Instead of removing the listener when it's processed, we remove it every time we try to swap suggestions.
Test
To test this problem, I've called the swapSuggestions twice in a row:
Hi again 🎉
I've fixed that if
swapSuggestionsis called twice in a row, then the suggestions are displayed incorrectly.The problem
OnGlobalLayoutListeneris called twice for single suggestion swap if we callswapSuggestionin the same frame. The problem is that the second time we callswapSuggestion,OnGlobalLayoutListenerhas still not being called, so it ends up calling it twice (or many times).The solution
Instead of removing the listener when it's processed, we remove it every time we try to swap suggestions.
Test
To test this problem, I've called the
swapSuggestionstwice in a row:Before the fix
After the fix