Both setOnMenuClickListener and setOnLeftMenuClickListener set mOnMenuClickListener - Githubissues

arimorty / floatingsearchview

A search view that implements a floating search bar also known as persistent search

https://github.com/arimorty/floatingsearchview/blob/master/README.md

Apache License 2.0

3.54k stars 667 forks source link

Both setOnMenuClickListener and setOnLeftMenuClickListener set mOnMenuClickListener #266

Open mattleibow opened 7 years ago

mattleibow commented 7 years ago

Both setOnMenuClickListener and setOnLeftMenuClickListener set the same mOnMenuClickListener field. Is this the correct functionality?

setOnMenuClickListener:
https://github.com/arimorty/floatingsearchview/blob/a0f8fbc90d98eb1b629c6295dd2d3577412e7b1e/library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java#L750-L752

setOnLeftMenuClickListener:
https://github.com/arimorty/floatingsearchview/blob/a0f8fbc90d98eb1b629c6295dd2d3577412e7b1e/library/src/main/java/com/arlib/floatingsearchview/FloatingSearchView.java#L1704-L1706