text action menu is not supported

arimorty / floatingsearchview

A search view that implements a floating search bar also known as persistent search

https://github.com/arimorty/floatingsearchview/blob/master/README.md

Apache License 2.0

3.54k stars 667 forks source link

text action menu is not supported #325

Open tom5079 opened 5 years ago

tom5079 commented 5 years ago

Text action menus without icon automatically go to the overflow section because of the line 178 in MenuView

List<MenuItemImpl> localActionItems = filter(mMenuItems, new MenuItemImplPredicate() {
    @Override
    public boolean apply(MenuItemImpl menuItem) {
        return menuItem.getIcon() != null && (menuItem.requiresActionButton() || menuItem.requestsActionButton());
    }
});

I don't think menuItem.getIcon() != null is nessesary because option always|withText without icon is possible

tom5079 commented 5 years ago

BTW, is this repository even mantained?