search

arimorty / floatingsearchview

A search view that implements a floating search bar also known as persistent search
https://github.com/arimorty/floatingsearchview/blob/master/README.md
Apache License 2.0
3.54k stars 668 forks source link

1 Feature Request and 1 Bug #64

Closed iambriccardo closed 8 years ago

iambriccardo commented 8 years ago

Bug: if i inserted the searchview above a static shape the shadow of the searchview is located only at the margins of the search.

Feature: add option to disable the suggestions, because on my layout I can't set in the best way my items because I see a big card with recyclerviewer that block me! That's all

arimorty commented 8 years ago

Hi @RiccardoBusetti ,

It is hard to tell the bug and feature you are describing. Can you provide more info or screenshots of the bug and why you need the feature?

iambriccardo commented 8 years ago

How i can upload photos from mobile?

iambriccardo commented 8 years ago

screenshot_20160605-190308

iambriccardo commented 8 years ago

Look at the shadow!

arimorty commented 8 years ago

I see. Does the FloatingSearchView cover the entire screen as specified here in step 2?

iambriccardo commented 8 years ago

Look here: https://github.com/RiccardoBusetti/Colombo https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2FRiccardoBusetti%2FColombo&sa=D&sntz=1&usg=AFQjCNGRx0M_JcOW28qGWqvfSps2cyRhwg Il 05 giu 2016 10:37 PM, "Ari" notifications@github.com ha scritto:

I see. Does the FloatingSearchView cover the entire screen as specified here https://github.com/arimorty/floatingsearchview/blob/master/README.md#usage in step 2?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arimorty/floatingsearchview/issues/64#issuecomment-223836139, or mute the thread https://github.com/notifications/unsubscribe/APFjmqhlstLePugz8iHCIs6eOXdZURz-ks5qIzORgaJpZM4IuSUC .

arimorty commented 8 years ago

In order for FloatingSearchView to work, you want to place the view at the very end of your top layout in a way that the view overlaps all your other views. Also, for margins, use the margin attributes provided by the view like floatingSearch_searchBarMarginLeft.

Please refer to the provided sample code before posting issues, but I am happy to answer any further questions.

Regards,

iambriccardo commented 8 years ago

Thanks i will try :) Il 05 giu 2016 11:48 PM, "Ari" notifications@github.com ha scritto:

In order for FloatingSearchView to work, you want to place the view at the very end of your top layout in a way that the view overlaps all your other views. Also, for margins, use the margin attributes provided by the view like floatingSearch_searchBarMarginLeft.

Please refer to the provided sample code before posting issues, but I am happy to answer any further questions.

Regards,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arimorty/floatingsearchview/issues/64#issuecomment-223839919, or mute the thread https://github.com/notifications/unsubscribe/APFjmv0g7FMT2e57wWRqX8t6jftCzplvks5qI0RIgaJpZM4IuSUC .

iambriccardo commented 8 years ago

schermata 2016-06-07 alle 19 38 50

Margin are setted the same!

arimorty commented 8 years ago

In FloatingSearchView, the shadow is part of the view that holds the search bar, so you have to subtract the shadow width from your desired padding. So, say you want an 8dp margin, you subtract the shadow padding which is about 3dp, and set the FloatingSearchView's margin to 5dp.

Again, it is included in the sample here https://github.com/arimorty/floatingsearchview/blob/master/sample/src/main/res/layout/activity_main_main_content.xml#L34 , please look at the sample before creating new issues.

Regards,