NPE in ManagedJMSConnectionFactory when no PasswordCredential is provided

[arinban]

Issue by arinban Thursday Feb 01, 2018 at 20:24 GMT Originally opened as https://github.com/arindam-bandyopadhyay/issue-test/issues/7

---

This issue has already been discussed on the mailing list, but i submit it here so that we can track it.

When no PasswordCredential can be retrieved in AbstractManagedConnectionFactory#createManagedConnection, the ManagedJMSConnectionFactory throws a NullPointerException in createXAConnection / createConnection. This can appear when the ra is used with jencks/spring outside any app server.

Here is a patch that makes it work:

protected javax.jms.XAConnection createXAConnection(PasswordCredential pc, javax.jms.ConnectionFactory cf ) throws JMSException { if (pc != null)

{ return ((XAConnectionFactory)cf).createXAConnection( pc.getUserName(), new String(pc.getPassword())); }

else

{ return ((XAConnectionFactory)cf).createXAConnection(); }

}

protected javax.jms.Connection createConnection(PasswordCredential pc, javax.jms.ConnectionFactory cf ) throws JMSException { if (pc != null)

{ return ((javax.jms.ConnectionFactory)cf).createConnection( pc.getUserName(), new String(pc.getPassword())); }

else

{ return ((javax.jms.ConnectionFactory)cf).createConnection(); }

}

Cheers, Guillaume Nodet

Environment

Operating System: All Platform: All

Affected Versions

[current]

[arinban]

Comment by arinban Thursday Feb 01, 2018 at 20:24 GMT

---

Original Issue:https://github.com/javaee/glassfish-genericjmsra/issues/7 Raised By:@glassfishrobot Created at:Fri Sep 23 08:28:25 IST 2005 Assigned To:@glassfishrobot

[arinban]

Comment by arinban Thursday Feb 01, 2018 at 20:24 GMT

---

@glassfishrobot Commented on Fri Sep 23 08:28:25 IST 2005 Reported by gnt@java.net

[arinban]

Comment by arinban Thursday Feb 01, 2018 at 20:24 GMT

---

@glassfishrobot Commented on Tue Oct 11 09:54:25 IST 2005 binod said: Added null checks for all types of ManagedConnectionFactories.