search

arindas / mac-on-linux-with-qemu

Runs macOS on linux with qemu.
MIT License
196 stars 18 forks source link

Updated run.sh. #17

Closed arindas closed 3 years ago

arindas commented 3 years ago

Separated dmg download step from dmg2img conversion step.

olfranco commented 3 years ago

Seems good to me, even if I was surprised and didn't understood at first the way you check the availability of the dmg2img command with the which (I'm not used to the to set -e flag, but I'm not a shellscripting expert...). Totally good.

The way I usually do this is I build an array of dependencies then loop over the items to check to availibility of each command, and echo a message informing the user about a missing dependency.