search

arindas / mac-on-linux-with-qemu

Runs macOS on linux with qemu.
MIT License
196 stars 18 forks source link

Bash strict mode #6

Closed Yamakaky closed 3 years ago

Yamakaky commented 3 years ago

You should enable http://redsymbol.net/articles/unofficial-bash-strict-mode/ on every script. dmg2img was not installed so I got 

./run.sh: line 12: dmg2img: command not found
*** Checking for disk image
*** Check if installer has been run
*** Looks like the install hasn't been done yet, lets install
*** Install!
qemu-system-x86_64: -drive if=pflash,format=raw,readonly,file=packaged-firmware/OVMF_CODE.fd: warning: short-form boolean option 'readonly' deprecated
Please use readonly=on instead
qemu-system-x86_64: -drive id=InstallMedia,format=raw,if=virtio,file=BaseSystem/BaseSystem.img: Could not open 'BaseSystem/BaseSystem.img': No such file or directory
arindas commented 3 years ago

This is awesome! Mind making a PR?

flaviencrochard commented 3 years ago

I would like to create the PR, but can't push a branch. Here is the patch :) Bash_strict_mode.txt