search

ariok / BWWalkthrough

BWWalkthrough is a simple library that helps you build custom walkthroughs for your iOS App
MIT License
2.76k stars 246 forks source link

Properly forward appearance callbacks #108

Closed nighthawk closed 6 months ago

nighthawk commented 7 years ago

Previously all child view controller had viewWillAppear called as soon as the walkthrough page appeared.

This commit fixes this by disabling the automatic forwarding of appearance information to all child views, and instead handles it manually both for the programatic case (calling gotoPage) and for the manual case where the scrolls the scroll view.

Both appearance and disappearance are forwarded correctly in my testing and there were no run-time issues of unbalanced appearance calls.

nighthawk commented 7 years ago

I've been following the guide: https://developer.apple.com/library/content/featuredarticles/ViewControllerPGforiPhoneOS/ImplementingaContainerViewController.html#//apple_ref/doc/uid/TP40007457-CH11-SW1