ariok / BWWalkthrough

BWWalkthrough is a simple library that helps you build custom walkthroughs for your iOS App

MIT License

2.76k stars 246 forks source link

RTL Support #98

Closed MojtabaHs closed 4 years ago

MojtabaHs commented 7 years ago

When choosing a RTL language in "Localization native development region" the FW behave odd and jumpy! Beside, order of the pages reversed (not excepted) and scroll direction not changes to RTL.

For testing, just set Localization native development region to some RTL language like "ar" or "fa".

MojtabaHs commented 7 years ago

Any updates yet?

ariok commented 7 years ago

I'm not working on it yet. I received your original message by email before you edited it. As you know, this is open source code, please feel free to edit it 💪🏻 😉 as you wish!

MojtabaHs commented 7 years ago

100 Please take a look 💪

ariok commented 7 years ago

@MojtabaHs I tried your code. When I launched the example it wasn't working properly (all the views were at wrong positions). I'll be glad to include your code in the next version! I keep the issue open.

MojtabaHs commented 7 years ago

Yes you are right. I forgot to check LTR after fixing RTL. What a shame. But I will fix it as soon as possible. This excelent framework should work for all nations.

reenaphilip commented 6 years ago

Is the RTL support done?

ariok commented 6 years ago

@reenaphilip no it has not been implemented. The previous pull request wasn't working correctly.

dornaCp commented 4 years ago

Is there any update on RTL? Is there any workaround?

ariok commented 4 years ago

I'll not add RTL soon. I'm working at a complete rework of this library with SwiftUI.