search

aririikonen / oracle

Full Oracle cookbook for Chef. Please see the README.md for further details.
http://oraarir.blogspot.fi/
44 stars 50 forks source link

Oracle client response file url is not being used in clibin.rb #2

Open jsanghi opened 10 years ago

jsanghi commented 10 years ago

Hello, I believe there is an issue with the oracle client installer recipe. I have provided the attribute node[:oracle][:client][:response_file_url], but it is not used at all in that recipe. In line 100, you call the runinstaller with the cli1123 template response file, rather than allowing user to use a different version response file or edit any parameters. In addition, there is a separate issue with the template file, which I will submit.

I do see that you get the response file from response file url on line 50 of cli_latest_patch.rb. You should do something similar in clibin.rb.

Thanks, Jason

dsp-eoss commented 10 years ago

Hi Jason,

Thanks for reporting this issue.

You're completely right, the code in clibin.rb is wrong, as it doesn't, but should, check for a non-empty value for node[:oracle][:client][:response_file_url], and act accordingly, the way the code in cli_latest_patch.rb does.

We'll add a fix to the next release of the cookbook, which should be coming out within the next couple weeks.

Thanks,

Dominique