search

ariscop / iris

web irc client for the atheme platform
Other
3 stars 0 forks source link

Autoscroll fails #2

Open ariscop opened 10 years ago

ariscop commented 10 years ago

Melli reports that the chat does not autoscroll. using chrome

Vordox commented 10 years ago

Something to do with emotes, most likely non pre cached emotes.

Breaks happens when you see the text that does not have the image, but as soon the image is loaded into the text, the slider "scrolls" up a bit and therefore auto breaks the auto scroll.

Hard to recreate, but this may be one of the possibilities.

ariscop commented 10 years ago

This particular bug was from before i added emote support. But it may be the same thing. i think when it moves the last-seen line marker it buggers up autoscroll, which checks if the scroll bar is at the exact bottom

megawac commented 10 years ago

AutoScroll is one of the first things I got working solidly for qwebirc - might just want to port mine?

You'll either need to add an adopt and disown event when you add or remove elements, use a MutationObserver or call updatePosition whenever you change the target element

ariscop commented 9 years ago

This should have been fixed by e6480d5b and 01f298eb, marking as closed untill i get reports of it breaking again

ariscop commented 9 years ago

Not that the fix is perfect, if you switch tabs it will rapidly scroll down, not sure why yet

ariscop commented 9 years ago

Tab switching breaks autoscroll on chrome

ariscop commented 9 years ago

By tab switching i meant iris tabs. Switching browser tabs seems to break it on firefox. odly enough, not on chrome

ariscop commented 9 years ago

/whois also seems to break autoscroll

ariscop commented 9 years ago

c00018d7 fixes the tab switching problem i had with chrome

ariscop commented 9 years ago

This is looking more and more like a chrome problem