search

ariselseng / camerarawpreviews

Camera Raw Previews app for Nextcloud
GNU Affero General Public License v3.0
53 stars 11 forks source link

Thumbs generate but previews don't #86

Closed D34DC3N73R closed 1 year ago

D34DC3N73R commented 2 years ago

I see thumbnails generated, but previews fail to load. These are ARW's from a sony camera.

image image image
ariselseng commented 2 years ago

@D34DC3N73R Are you sure there is preview information in your file? This app only extracts the jpeg already inside the file.

ariselseng commented 2 years ago

@D34DC3N73R Also, you could send me a sample file that has this issue and I could see if I can reproduce your issue.

D34DC3N73R commented 2 years ago

I sent a sample to your email. I'm sure it used to work because I've previously previewed ARW files from the same camera. Unfortunately, I don't know the exact version it stopped working. Thanks for taking a look!

andreybavt commented 1 year ago

Hi, I'm having the same problem but with opening NEF files. Camera RAW Previews version is 0.8.0 I'm running NextCloud 25.0.1 from TrueNAS.

image

Same as above, a thumbnail is created, but when I open a NEF file itself there's an infinite spinner. The image that I'm trying to open is 24 MB

Here's a small file example that doesn't work infrared.nef.zip

I'm curious to know about the fix

D34DC3N73R commented 1 year ago

I've updated to Nextcloud 24.0.7 and still have the same issue, with CRP v0.8.0. I haven't found a solution yet.

andreybavt commented 1 year ago

another strange thing that I noticed: Opening a NEF file directly doesn't work (infinite spinner), but switching to next/previous and going back does result in a working preview.

ivan11paths commented 1 year ago

I have the same problem with Olympus RAWs. And I confirm the forward/back operation that @andreybavt comments.

ariselseng commented 1 year ago

I am pretty sure this is a regression in the viewer app. Does anyone care to downgrade the viewer app to a known good time/version? As long as the this app provides previews to nextcloud, it is up to the individual app to use it correctly.

jkhsjdhjs commented 1 year ago

I just tested several versions of the viewer app and the last good version of the v24 branch is 24.0.3. I only tested 25.0.1 of the v25 branch, but I guess all versions of the v25 branch are broken.

ariselseng commented 1 year ago

I just tested several versions of the viewer app and the last good version of the v24 branch is 24.0.3. I only tested 25.0.1 of the v25 branch, but I guess all versions of the v25 branch are broken.

Thank you. I would appreciate if you or somebody else could open an issue at the viewer repo.

jkhsjdhjs commented 1 year ago

Since there haven't been many changes between 24.0.3 and 24.0.4, I'm pretty sure that this commit broke the file handler logic: https://github.com/nextcloud/viewer/commit/e2c48013628cf19c2519cb2c7efb96014dcdb591

@andreybavt has already created an issue: https://github.com/nextcloud/viewer/issues/1450